Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: withRecover cannot recover panic #1169

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

wanyuqin
Copy link
Contributor

What is the purpose of the change

Fix the problem that the withRecover method cannot capture panic normally

Brief changelog

  • PanicHandler is converted from a variable to a type.
  • Define a default DefaultPanicHandler method.
  • WithRecover defines a variadic parameter handlers, and if none are passed, it adds DefaultPanicHandler to the handlers.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wanyuqin wanyuqin closed this Sep 22, 2024
@wanyuqin wanyuqin reopened this Sep 22, 2024
@wanyuqin
Copy link
Contributor Author

@yuz10 大佬麻烦帮忙看下

@yuz10 yuz10 merged commit ac4e3d6 into apache:master Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants